Skip to content

Conversation

litetex
Copy link
Member

@litetex litetex commented Oct 27, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I'm currently experimenting with the Nightly and how to get it into an F-Droid repo.
So far it looks quite good however all nightly builds have the same version and name which confuses F-Droid.

Example

This PR make it possible to control the version code and name.
This makes it possible to e.g. set -DversionNameSuffix=-<nightlyBuildId>-<date> -DversionCodeOverride=<nightlyBuildId> which should then result in distinguishable versions.

Related: TeamNewPipe/NewPipe-nightly#19

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 27, 2024
Copy link

@TobiGr TobiGr merged commit 94f992a into TeamNewPipe:dev Oct 27, 2024
8 checks passed
@litetex litetex deleted the better-control-over-version branch October 27, 2024 20:46
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants