Skip to content

Conversation

ShareASmile
Copy link
Collaborator

@ShareASmile ShareASmile commented Jul 6, 2024

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

NewPipe's Import database and Export database settings were moved from Content to a new section in v0.27.0

  1. hence update Assamese, Hindi & Punjabi Readme's
  2. Add matrix link to hindi, punjabi and assamese
  3. Improve above mentioned Readmes.
  4. Fix assamese readme LiberaPay donate button not showing and fix weird formatting

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

also translate Warning in hindi & punjabi language Readme's
add missing link #supported-services in hindi readme (that is #समर्थित-सेवाएँ}
improve translation of supported services in punjabi
Use Fdroid Hindi badge instead of english in hindi readme
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 6, 2024
@github-actions github-actions bot added size/medium PRs with less than 250 changed lines and removed size/small PRs with less than 50 changed lines labels Jul 6, 2024
oh! I missed this one earlier
@AudricV AudricV added meta Related to the project but not strictly to code localisation / translation Everything that has to do with translations or Weblate labels Jul 6, 2024
@AudricV AudricV changed the title Update backup and restore explanation & improve hindi, punjabi and assamese Readme's Update backup and restore explanation & improve hindi, punjabi and assamese READMEs Jul 6, 2024
Copy link
Collaborator

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saurmandal If you have the time, could you also have a look? I'm not good with the fancy words.


NewPipe এ বৰ্তমান এই সেৱাসমূহ সমৰ্থন কৰে:

<!-- আমি সেৱাৰ ৱেবছাইটসমূহৰ সৈতে পৃথকে লিংক কৰোঁ যাতে মানুহে ভুলবশতঃ তেওঁলোকে নিবিচৰা ৱেবছাইট এটা খুলিব নোৱাৰে। -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You speak both Punjabi and Assamese!? Or is this machine translation? Your previous changes to this file were all technical so I assumed that wasn't the case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShareASmile Still waiting for your answer. If you know Assamese then go ahead. If this is machine translated please revert it. We have no idea what it says.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You speak both Punjabi and Assamese!? Or is this machine translation?

I speak Punjabi, Hindi & English languages. They are used routinely in educational institutions, offices, commercial establishments in our region.

As for assamese goes, this is a machine translation, So for a long time I was trying to get in touch with a couple of batchmates of my cousin who belong to Assam region to get a word on changes in assamese Readme, finally succeeded to get in touch with one of them and wait didn't go in vain. He found it to be pretty better than before, possessing all meaningful sentences. So if you think it is good to go, ok, if not we can revert that change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I speak Punjabi, Hindi & English languages.

This set I can understand. It was the Assamese that confused me. It's like someone knowing Bengali, Tamil and Gujarati at the same time. Not a natural combo at all. xD

Sure, then. The Assamese can stay.

Also, let's just merge this. You can open a new PR for the additional changes you mentioned below.

@opusforlife2
Copy link
Collaborator

@ShareASmile ?

@Profpatsch
Copy link
Contributor

@ShareASmile Are you gonna react to any of the review comments? Otherwise I’m gonna have to close this PR.

@ShareASmile
Copy link
Collaborator Author

For a long time I was trying to get in touch with old students from Assam region who studied with my cousins to get a word on changes in assamese Readme, finally succeeded to get in touch with one of them and got positive feedback about changes in assamese Readme.

I have added reply to the review accordingly. I do intend to push some more changes according to the recent new additions to English README tomorrow.

Apologies for the long delay, I should have written some lines for explanation about the delay here.

@ShareASmile
Copy link
Collaborator Author

Also, let's just merge this. You can open a new PR for the additional changes you mentioned.

Thanks opus, That sounds fine, additional changes can be done in another PR.

@TobiGr TobiGr merged commit 1408150 into TeamNewPipe:dev Nov 20, 2024
1 check passed
@Profpatsch
Copy link
Contributor

I have added reply to the review accordingly. I do intend to push some more changes according to the recent new additions to English README tomorrow.

Apologies for the long delay, I should have written some lines for explanation about the delay here.

Thanks for the reply, no worries! It’s a step-by-step process :)

@ShareASmile ShareASmile deleted the update-assamese-hindi-punjabi-README branch February 7, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants