-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Open
Labels
codequalityImprovements to the codebase to improve the code qualityImprovements to the codebase to improve the code qualityhelp wantedHelp is wanted in fixing this issueHelp is wanted in fixing this issueissue listGeneric Issue to track overall progress of specific issues preferably using markdown checkboxesGeneric Issue to track overall progress of specific issues preferably using markdown checkboxesplayerIssues related to any player (main, popup and background)Issues related to any player (main, popup and background)rewriteIssues and PRs related to rewriteIssues and PRs related to rewrite
Description
I and Stypox noticed some strange things while reviewing/refactoring the player #8170 (which were also there before the refactoring):
- When the playerservice is removed the complete app is killed (not gracefully terminated) by calling
Runtime.getRuntime().halt(0): Refactor player and extract UI components #8170 (comment) - Refactor player and extract UI components #8170 (comment) - here somehow a velocity is set to a position.
- should be addressed (or removed) Refactor player and extract UI components #8170 (comment)
//TODO check if this causes black screen when switching to fullscreen - should be addressed (or removed) Create media session UI and fix player notification #8678 (comment)
NewPipe/app/src/main/java/org/schabi/newpipe/player/mediasession/MediaSessionPlayerUi.java
Line 70 in e9e9e80
// TODO decide whether to handle ACTION_HEADSET_PLUG or not
Other things to do:
- Add an UI that handles setting up a media session to send media information to the system, and try to fix the various issues with the player notification (e.g. wrong thumbnail, non-seekable current time, ...): Create media session UI and fix player notification #8678
- Properly implement a Picture In Picture popup: Use picture-in-picture (PIP) for the popup player on Android >= 8.0 #8750
- Make the playback parameters menu show up even when in popup mode
- Refactor player and extract UI components #8170 (comment)
- Refactor how the player is started or changed: Refactor how the player is started or changed #7673
Metadata
Metadata
Assignees
Labels
codequalityImprovements to the codebase to improve the code qualityImprovements to the codebase to improve the code qualityhelp wantedHelp is wanted in fixing this issueHelp is wanted in fixing this issueissue listGeneric Issue to track overall progress of specific issues preferably using markdown checkboxesGeneric Issue to track overall progress of specific issues preferably using markdown checkboxesplayerIssues related to any player (main, popup and background)Issues related to any player (main, popup and background)rewriteIssues and PRs related to rewriteIssues and PRs related to rewrite
Type
Projects
Status
Todo