Potential performance problem with MediaSessionManager#get/setMetadata

[litetex]

Checklist

• I am using the latest version - 0.21.9 / develop
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

Run the app / play a video (in the background).

What I did:
Opened a video and ran it in the background.

Details

NewPipe performs a progress update when the player is active every 500ms/1s (was increased to 1s in #7071).

However when this progress update is executed the setMetadata-method seems to be very costly (takes 40-80% of the time of the complete progress update) as seen when profiling the app:

Emulator Pixel 3a

cpu-emulator-Pixel3a.zip

Emulator Pixel C

cpu-emulator-PixelC.zip

Note: I'm unable to determine if this is just a android emulator problem as I can't profile my real phone (crashes with SIGSEV in HeapTaskDaemon/libc when running the profiler)

Device info

• Android version/Custom ROM version: Android 11 - API 30
• Device model: Android Emulator Pixel 3a/Pixel C

[Redirion]

For the performance of this method I wonder if this is not an issue of inspecting the performance on the debug build. Did you also try to check how the performance is, without all the Logs?

edit: getThumbnail is never null. So don't mind the pre edited part.
edit2: oh no, I confused myself. It is indeed a problem! Original comment:

while looking at setMetaData I noticed another issue:

// setMetadata only updates the metadata when any of the metadata keys are null mediaSessionManager.setMetadata(getVideoTitle(), getUploaderName(), showThumbnail ? getThumbnail() : null, duration);

in other words, if showThumbnail is false, metaData updates do never happen!

I will create a PR for that.

[Redirion]

@litetex can you check your logcat: does "setMetadata: N_Metadata update" appear every 1 seconds? that would be a bug. Please try my PR in comparison. Do you have "Show thumbnails" set to "off"?

[litetex]

Okay I tested the stuff a bit and found out that the metadata updates - that are done every second - are completely useless.
They should only be done when the metadata changes e.g. when opening a new video.

[Redirion]

yes, and that's how it works / should work. When I was testing my PR, it was working this way.
What is the log output of setMetadata: N_Metadata update for you?

[litetex]

@Redirion
It seems to be fixed as it only occurs once in the log 😄
With my code on top - where the update only occurs when the metdata is changed - this is definitely fixed.