High CPU usage

Checklist

• I am using the latest version - 0.21.9
• [x ] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• [ x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• [ x] This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

Search for any song.
Press background play
Measure cpu time with adb shell top
Turn the screen off to disable gui to make sure gui is not rendering something

Actual behavior

CPU usage either 6% or 10% in top for newpipe process

Expected behavior

0% cpu usage for newpipe process as with other players where only media.codec is using 1% cpu

Device info

Moto G4 stock
Android 7

[opusforlife2]

Please fill out the template properly.

[litetex]

Okay I debugged this a bit:

Used video: https://www.youtube.com/watch?v=GDqxvHSPu5c
Quality: 360p

Device: Huawei P20lite (CPU: 4x 2.36 GHz, 4x 1.7 GHz)
Complete available CPU-percent on device: 800% (8 cores)
OS: Android 9.1 / EMUI 9.1

App	Mode	CPU usage details (from/max=800%)	complete avg CPU usage of all related apps (calculated down to max=100%)
NewPipe	Normal or Full screen	30-50% NewPipe + 14% media.codec + 11% surfaceflinger + 11% audioserver	9.5%
NewPipe	Background (app closed on homescreen)	30-50% NewPipe + 14% media.codec + 11% audioserver	8.1%
Youtube	Normal or Full screen	30-50% YouTube + 5% media.codec + 13% surfaceflinger + 10% audioserver	8.5%
Built-in audio player	Background (app closed on homescreen) m4a file	5% huawei music player + 13% audioserver + 11% media.codec + 11% mediaserver	5%

Turn the screen off to disable gui to make sure gui is not rendering something

GUI rendering is done on the GPU side and should have little to no effect on the above mentioned cpu processes

So in my opinion everything works as expected:

• The YouTube app is a bit faster because it likely uses better codes than NewPipe (media.code only requires half the cpu compared to NewPipe)
• Running the built-in music player doesn't require any network-I/O activity (as can be seen when as the apps cpu usage is only 1/6-1/10 compared to YT or NewPipe) however it requires the additional process mediaserver

[litetex]

@thefalsedev
I also added the missing checklist, please fill it out 😄

I am comparing it now with youtube vanced music.
On vanced on the same file I am getting 2-3% cpu usage for vanced process and 1% for media.codec.
On newpipe I am getting either 6%-10% depending on whatever I dont know. Right now I am getting 7% and it's stable. When I restart it I am getting anything between 6 and 10 (in apps force stop).
Note that this is constant usage and has nothing to do with the network, as network is using only momentary.
This was tested on the same AAC file.
Also note this has impact on how long you can go outdoors and listen to the music however I havent tested it yet, but i will test it ASAP.
Basically by using adb shell dumpsys battery I can check actual battery usage and how big impact it is.
I think youtube app is not good comparison as it's total crap.
OK I restarted it properly now and I am getting 6%. Looks like it starts at 6 and keeps growing or something, will keep an eye on this.

For newpipe:

PID USER     PR  NI CPU% S  #THR     VSS     RSS PCY Name
14426 u0_a245  20   0   6% S    59 1166856K 126628K  fg org.schabi.newpipe
3664 mediacod 20   0   1% S    16 120608K   2772K  fg media.codec

For vanced:

PID USER     PR  NI CPU% S  #THR     VSS     RSS PCY Name
14945 u0_a130  20   0   3% S   146 1876368K 162936K  fg com.vanced.android.apps.youtube.music
3664 mediacod 20   0   1% S    18 122832K   3484K  fg media.codec

For musicolet opus file:

3664 mediacod 20   0   1% S    20 125280K   3628K  fg media.codec

We are talking about new pipe process and not other processes, and with the screen turned off while you are outdoors.

After couple of songs it got 7% and after another few it has now 8%. I measured the battery, it consumes 0.041 mAh per second so far so it gives 16h playback. I think it's not bad compared to other players I got and their playtime.
However this growing cpu usage is concerning so if it continues to grow then the practical playtime will get reduced.
I will keep playing and measuring the battery load.

   PID USER     PR  NI CPU% S  #THR     VSS     RSS PCY Name
14426 u0_a245  20   0   8% S    71 1193852K 121140K  fg org.schabi.newpipe
 3664 mediacod 20   0   1% S    16 120608K   2376K  fg media.codec

The threads are looking like this:

  PID   TID USER     PR  NI CPU% S     VSS     RSS PCY Thread          Proc
14426 14436 u0_a245  20   0   5% S 1177052K 119672K  fg HeapTaskDaemon  org.schabi.newpipe
14426 16142 u0_a245   4 -16   1% S 1177052K 119672K  fg ExoPlayer:Playb org.schabi.newpipe
17821 17821 shell    20   0   1% R  13640K   2392K  fg top             top
 3664 17775 mediacod 18  -2   0% S 120608K   2172K  fg le.opus.decoder media.codec

For now, for over 35min it consumed 0.046 mAh per second.