Crash in lists (ViewHolder views not attached)

[andrewshadura]

Checklist

• I am using the latest version.
• I checked, but didn't find any duplicates of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Set up peertube.debian.social as the peertube instance
2. Open Trending/Local/whatever
3. Attempt to scroll beyond the last element

Actual behaviour

Crash (see below).

Expected behavior

I’d expect more video thumbnails to appear.

Logs

Exception

• User Action: ui error
• Request: App crash, UI failure
• Content Country: GB
• Content Language: en-GB
• App Language: en_GB
• Service: none
• Version: 0.20.0
• OS: Linux Android 9 - 28

Crash log

java.lang.IllegalStateException: ViewHolder views must not be attached when created. Ensure that you are not passing 'true' to the attachToRoot parameter of LayoutInflater.inflate(..., boolean attachToRoot)
	at androidx.recyclerview.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:7080)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6235)
	at androidx.recyclerview.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:288)
	at androidx.recyclerview.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:345)
	at androidx.recyclerview.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:361)
	at androidx.recyclerview.widget.GapWorker.prefetch(GapWorker.java:368)
	at androidx.recyclerview.widget.GapWorker.run(GapWorker.java:399)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6680)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

---

Device info

• Device model: Mi Box S

[Stypox]

This was already reported a while ago, and there is unfortunately no way to reproduce. It has nothing to do with PeerTube in particular, but just with lists. If there will be a way to reproduce this consistently this issue can be reopened, but as of now there is none. Thank you for the report anyway! ;-)

[andrewshadura]

Well, it happens here all the time, each time, is there any way I can use this to help?

[opusforlife2]

Ah. Then we probably need logs, don't we, @Stypox?

[Stypox]

I don't think logs would help. I already tried fixing this bug but failed, since NewPipe is already doing what the error suggests to do:

Ensure that you are not passing 'true' to the attachToRoot parameter of LayoutInflater.inflate(..., boolean attachToRoot)

[opusforlife2]

So it's an OS bug that NewPipe can't work around. Okay. Sorry, @andrewshadura.

[andrewshadura]

Can’t we at least catch the exception in a better way?

[Stypox]

The issue is, that exception does not come from NewPipe's code, but from some other library code. Therefore catching the error and ignoring it would probably not solve anything, because the app would be put in an unstable state where something is wrong and would crash again with another kind of crash.

[andrewshadura]

I’ve just found an interesting fact. First of all, I’m using a remote to navigate the list. Second, it only happens when I navigate it in a particular way. The screen is a grid of 2½ rows by 5 columns. For some reason, only 12 thumbnails are displayed:

The crash usually happens when I press "down" while the last element is focused (but not every time, I haven’t found the exact 100% reproducible sequence).

I’m wondering, can the crash be somehow related with the fact fewer items have been preloaded than the grid expects? I don’t understand it from the code, how is the number of items to preload determined?