Share does not work from soundcloud

[garawaa]

Sharing does not work

[TobiGr]

When playing a video and sharing it, the timestamp is appended to the URL. Replacing the & with # makes SoundCloud recognize it.

https://soundcloud.com/mahdyar/agh&t=40 -> https://soundcloud.com/mahdyar/agh#t=40

[TobiGr]

Ah wait. We produce an invalid URL here in the first place. We should check the cause for this, too. I guess people only thought about YouTube when changing the share logic.

[wb9688]

@TobiGr: And this is why URL exists… we really shouldn't append Strings and hope it becomes a valid URL.

Edit: we also shouldn't even use URL there client-side, but add an extractor-side API for getting an URL with timestamp.

[spacemonkey1101]

Hey, I would love to work on this. Can you assign me?

[opusforlife2]

I guess people only thought about YouTube when changing the share logic.

(sideways glance at @Stypox 🤭)

[opusforlife2]

@spacemonkey1101 Sure. Also have a look at #3264.

[spacemonkey1101]

I am unable to build because of the checkstyle errors already present. Should I solve them one by one or is there a way to disable checkstyle checks.

[B0pol]

I am unable to build because of the checkstyle errors already present. Should I solve them one by one or is there a way to disable checkstyle checks.

could paste the error log?

there should be only warnings, no errors. If you want to disable checkstyle comment or remove runCheckstyle here.

[opusforlife2]

@spacemonkey1101 So, could you get past the build issue?