Skip to content

Conversation

@cherriae
Copy link
Member

@cherriae cherriae commented Jan 7, 2025

Summary

This is for the 2025 Season Scouting App,

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. subsystem).
  • This PR is not a code change (e.g. README, typehinting, examples, refactoring, ...)

**Done:** Models.py, list.html (?), add.html, field-2025.png

**In Progress**: Edit.html

**Not started**: Leaderboard.html, matches.html, team.html
Copy link
Member Author

@cherriae cherriae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@cherriae cherriae marked this pull request as draft January 8, 2025 01:59
@cherriae cherriae self-assigned this Jan 8, 2025
@cherriae cherriae added enhancement New feature or request help wanted Extra attention is needed labels Jan 8, 2025
@cherriae cherriae changed the title Add files todo and update 2025 SZN Jan 8, 2025
Copy link
Member Author

@cherriae cherriae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug Fixes

cherriae and others added 3 commits January 9, 2025 13:51
…tion

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Member Author

@cherriae cherriae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add raw scouting data to compare page

@cherriae
Copy link
Member Author

cherriae commented Jan 9, 2025

Known Issues:

When Team is deleted, the owner is gone from the team but then there is no owner for the team and so one of admin will become owner or member if no admins will become owner.
Solution: When owner leaves, team gets deleted

Edit: When user leaves the team, scouting data disappear from list.html but still there, suspect that there no team number and it breaks: WARNING:app.team.team_utils:No team found with team_number: 334
Solution: Use if statements to check for team_number

Copy link
Member Author

@cherriae cherriae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need people to test if everything works

…tion

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
cherriae and others added 4 commits January 21, 2025 11:01
…rough an exception

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@cherriae cherriae marked this pull request as ready for review January 22, 2025 19:20
@cherriae cherriae requested a review from elvizer January 22, 2025 19:21
@cherriae
Copy link
Member Author

Need to people to do rigid testing

cherriae and others added 4 commits January 22, 2025 14:42
…mote source

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rough an exception

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Member Author

@cherriae cherriae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@elvizer elvizer merged commit 9655d54 into main Jan 22, 2025
7 checks passed
@cherriae cherriae deleted the 2025 branch February 1, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants