Docker optimizations #3904
Open
Docker optimizations #3904
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wilmarguida <[email protected]>
…ing tini Signed-off-by: wilmarguida <[email protected]>
Signed-off-by: wilmarguida <[email protected]>
Signed-off-by: wilmarguida <[email protected]>
Signed-off-by: wilmarguida <[email protected]>
Signed-off-by: wilmarguida <[email protected]>
Signed-off-by: wilmarguida <[email protected]>
Signed-off-by: wilmarguida <[email protected]>
|
Thanks for starting to improve the container image! 😄 I think there is more to clean, but at least that's a start. And yes indeed, having a proper init process is crucial here. |
10 tasks
|
@edysli yes I was very temped to a big refactor but that is for after my vacation ;) I will for sure follow this up with more PRs |
|
Thanks for the PR, looks good on first sight. I have a bit of vacation now as well but will definitely get back to this. |
This was referenced Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple quick fixes in the Dockerfile where ee7d611 is the most important one.
In the current setup there is a possibility for zombie processes since Docker only cares about the PID1 and other processes might not get killed since Bash isn't the greatest in forwarding the signals.
Using a small processmanager like tini solves all these issues :)
The rest are just little convenience fixes or little cleanups (armv7 support dropped, rust works fine on aarch64 from repo now)
Will followup this PR with some more optimizations but this is the most important one.