Skip to content

Conversation

@KiwiKilian
Copy link
Contributor

@KiwiKilian KiwiKilian commented Sep 9, 2025

The link to External Data Loading on the Query Integration page currently throws a 404.

Summary by CodeRabbit

  • Documentation
    • Corrected a link in the Router integrations guide to point to the proper External Data Loading page in the React framework section. This fixes navigation from that note and ensures readers can access the referenced guidance without errors. No functional changes to the product; content remains otherwise unchanged and reduces confusion.

@github-actions github-actions bot added the documentation Everything documentation related label Sep 9, 2025
@nx-cloud
Copy link

nx-cloud bot commented Sep 9, 2025

View your CI Pipeline Execution ↗ for commit 14da07b

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-09 07:09:54 UTC

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Walkthrough

Single documentation edit updating a relative link path in an IMPORTANT note within docs/router/integrations/query.md. No other content or public APIs changed.

Changes

Cohort / File(s) Summary
Docs link path update
docs/router/integrations/query.md
Adjusted relative link in IMPORTANT note from ../framework/react/guide/external-data-loading.md to ../../framework/react/guide/external-data-loading.md.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A nibble of docs, a hop through the trees,
I tweaked a path with delicate ease.
Breadcrumbs aligned, no routes astray,
Now links will guide the reader’s way.
Thump-thump hooray! 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99d9044 and 14da07b.

📒 Files selected for processing (1)
  • docs/router/integrations/query.md (1 hunks)
🔇 Additional comments (1)
docs/router/integrations/query.md (1)

7-7: Approve relative link; fix verification script

From docs/router/integrations/query.md to docs/router/framework/react/guide/external-data-loading.md requires two parent traversals; ../../framework/react/guide/external-data-loading.md is correct. Approved. Optionally prefer site-root or alias-based links to avoid future path churn.

Run to verify file existence and catch any remaining incorrect links:

#!/usr/bin/env bash
set -euo pipefail

# Ensure target doc exists
if [[ -f docs/router/framework/react/guide/external-data-loading.md ]]; then
  echo "OK: target exists."
else
  echo "Missing: docs/router/framework/react/guide/external-data-loading.md" >&2
  exit 1
fi

# Find any lingering one-level-up links to external-data-loading.md
rg -nP "\.\./framework/react/guide/external-data-loading\.md" -g "docs/router/**/*.md" || echo "No remaining incorrect links."

Likely an incorrect or invalid review comment.

Pre-merge checks (2 passed, 1 inconclusive)

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The pull request does not include a detailed description beyond the title, making it difficult to confirm that it accurately explains the updated link path in docs/router/integrations/query.md. This lack of context renders the description too vague to determine whether it aligns with the summarized change. As a result, the check is inconclusive. Please expand the pull request description to explicitly reference the update to the external data loading link path in docs/router/integrations/query.md and note that the path was changed from ../framework/react/guide/external-data-loading.md to ../../framework/react/guide/external-data-loading.md so reviewers can verify alignment.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately summarizes the primary documentation change by indicating that the external data loading link path is being fixed, and it follows the conventional “docs:” prefix without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 9, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5109

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5109

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5109

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5109

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5109

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5109

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5109

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5109

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5109

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@5109

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5109

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5109

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5109

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5109

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5109

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5109

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5109

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5109

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5109

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5109

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5109

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5109

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5109

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5109

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5109

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@5109

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5109

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5109

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5109

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5109

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@5109

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@5109

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@5109

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5109

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5109

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5109

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5109

commit: 14da07b

@nlynzaad
Copy link
Contributor

nlynzaad commented Sep 9, 2025

Thanks for the update

@nlynzaad nlynzaad merged commit d939463 into TanStack:main Sep 9, 2025
6 checks passed
LadyBluenotes pushed a commit to LadyBluenotes/router that referenced this pull request Sep 9, 2025
The link to External Data Loading on the [Query
Integration](https://tanstack.com/router/latest/docs/integrations/query)
page currently throws a 404.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Corrected a link in the Router integrations guide to point to the
proper External Data Loading page in the React framework section. This
fixes navigation from that note and ensures readers can access the
referenced guidance without errors. No functional changes to the
product; content remains otherwise unchanged and reduces confusion.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants