Skip to content

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented Sep 12, 2025

Standalone components have been the default since Angular 19

Summary by CodeRabbit

  • Documentation
    • Updated Angular guides and quick start to remove standalone component usage in examples for consistency.
  • Chores
    • Aligned Angular example apps to non-standalone components across auto-refetching, basic, basic-persister, and optimistic-updates samples.
  • Tests
    • Updated test components to non-standalone configuration to match revised examples and docs.

Copy link
Contributor

coderabbitai bot commented Sep 12, 2025

Walkthrough

Removed the standalone: true flag from Angular @component decorators across documentation snippets, example apps, and test components. No other code, templates, or logic were changed.

Changes

Cohort / File(s) Summary of changes
Docs: Angular
docs/framework/angular/guides/mutations.md, docs/framework/angular/guides/queries.md, docs/framework/angular/guides/query-cancellation.md, docs/framework/angular/overview.md, docs/framework/angular/quick-start.md
Removed standalone: true from @Component snippets; examples now show non-standalone components.
Examples: Angular apps
examples/angular/auto-refetching/src/app/app.component.ts, examples/angular/optimistic-updates/src/app/app.component.ts, examples/angular/basic-persister/src/app/components/post.component.ts, examples/angular/basic-persister/src/app/components/posts.component.ts, examples/angular/basic/src/app/components/post.component.ts
Deleted standalone: true from component decorators; components become non-standalone. No other changes.
Tests: angular-query-experimental
packages/angular-query-experimental/src/__tests__/inject-mutation-state.test.ts, packages/angular-query-experimental/src/__tests__/inject-mutation.test.ts, packages/angular-query-experimental/src/__tests__/inject-query.test.ts
Removed standalone: true from test components’ @Component metadata; test logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore(angular-query): remove standalone component markers" is concise, follows conventional commit scope, and accurately summarizes the primary change (removing standalone: true across Angular docs, examples, and tests), so a teammate scanning history can understand the main intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I nudge my nose at flags once bold,
Standalone burrows now left cold.
In docs and tests, I tidy through—
Small hops, clean trails, nothing new.
Components nest, the garden’s neat,
Fewer sprouts beneath my feet. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d179168 and 0de16f5.

📒 Files selected for processing (13)
  • docs/framework/angular/guides/mutations.md (0 hunks)
  • docs/framework/angular/guides/queries.md (0 hunks)
  • docs/framework/angular/guides/query-cancellation.md (0 hunks)
  • docs/framework/angular/overview.md (0 hunks)
  • docs/framework/angular/quick-start.md (0 hunks)
  • examples/angular/auto-refetching/src/app/app.component.ts (0 hunks)
  • examples/angular/basic-persister/src/app/components/post.component.ts (0 hunks)
  • examples/angular/basic-persister/src/app/components/posts.component.ts (0 hunks)
  • examples/angular/basic/src/app/components/post.component.ts (0 hunks)
  • examples/angular/optimistic-updates/src/app/app.component.ts (0 hunks)
  • packages/angular-query-experimental/src/__tests__/inject-mutation-state.test.ts (0 hunks)
  • packages/angular-query-experimental/src/__tests__/inject-mutation.test.ts (0 hunks)
  • packages/angular-query-experimental/src/__tests__/inject-query.test.ts (0 hunks)
💤 Files with no reviewable changes (13)
  • examples/angular/basic/src/app/components/post.component.ts
  • packages/angular-query-experimental/src/tests/inject-mutation.test.ts
  • examples/angular/basic-persister/src/app/components/post.component.ts
  • docs/framework/angular/quick-start.md
  • docs/framework/angular/guides/query-cancellation.md
  • docs/framework/angular/overview.md
  • docs/framework/angular/guides/queries.md
  • examples/angular/auto-refetching/src/app/app.component.ts
  • examples/angular/basic-persister/src/app/components/posts.component.ts
  • packages/angular-query-experimental/src/tests/inject-query.test.ts
  • examples/angular/optimistic-updates/src/app/app.component.ts
  • packages/angular-query-experimental/src/tests/inject-mutation-state.test.ts
  • docs/framework/angular/guides/mutations.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added documentation Improvements or additions to documentation package: angular-query-experimental labels Sep 12, 2025
Copy link

nx-cloud bot commented Sep 12, 2025

View your CI Pipeline Execution ↗ for commit 0de16f5

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 28s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-12 13:02:47 UTC

@arnoud-dv arnoud-dv changed the title chore(angular-query): remove component markers chore(angular-query): remove standalone component markers Sep 12, 2025
@arnoud-dv arnoud-dv force-pushed the chore/angular-remove-standalone branch from 6a763c0 to 0de16f5 Compare September 12, 2025 13:00
Copy link

pkg-pr-new bot commented Sep 12, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9647

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9647

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9647

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9647

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9647

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9647

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9647

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9647

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9647

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9647

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9647

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9647

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9647

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9647

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9647

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9647

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9647

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9647

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9647

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9647

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9647

commit: 0de16f5

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.77%. Comparing base (2492ed1) to head (0de16f5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9647       +/-   ##
===========================================
+ Coverage   45.51%   87.77%   +42.25%     
===========================================
  Files         209       16      -193     
  Lines        8379      319     -8060     
  Branches     1898       75     -1823     
===========================================
- Hits         3814      280     -3534     
+ Misses       4118       34     -4084     
+ Partials      447        5      -442     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 87.00% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnoud-dv arnoud-dv merged commit e3b40d4 into TanStack:main Sep 12, 2025
8 checks passed
@arnoud-dv arnoud-dv deleted the chore/angular-remove-standalone branch September 12, 2025 13:09
Hellol77 pushed a commit to Hellol77/query that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation package: angular-query-experimental

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant