-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
docs(angular-query): update Angular Zoneless doc #9616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(angular-query): update Angular Zoneless doc #9616
Conversation
WalkthroughDocumentation updates adjust Zoneless Angular links from experimental to stable paths and make a minor bullet marker formatting change. No code or functional modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
View your CI Pipeline Execution ↗ for commit 0eee76b
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/framework/angular/angular-httpclient-and-other-data-fetching-clients.md (2)
14-14
: Use “stability” instead of “stableness”.Minor wording fix for clarity.
- Unit tests and SSR can use the resulting application _stableness_ information to wait for pending requests to finish. + Unit tests and SSR can use the resulting application stability information to wait for pending requests to finish.
14-14
: Trim the trailing hash in PendingTasks URL.The page resolves without a fragment; dropping “#” avoids a no-op fragment.
Reference: PendingTasks API. (angular.dev)- [`PendingTasks`](https://angular.dev/api/core/PendingTasks#) + [`PendingTasks`](https://angular.dev/api/core/PendingTasks)docs/framework/angular/zoneless.md (1)
8-8
: Good update to stable Zoneless link; consider a small phrasing tweak.Optional edit for style and readability.
-Among Zoneless benefits are improved performance and debugging experience. For details see the [Angular documentation](https://angular.dev/guide/zoneless). +Zoneless benefits include improved performance and a better debugging experience. For details, see the [Angular documentation](https://angular.dev/guide/zoneless).Optionally, you could also reference the provider API for discoverability:
provideZonelessChangeDetection
. (angular.dev)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/framework/angular/angular-httpclient-and-other-data-fetching-clients.md
(1 hunks)docs/framework/angular/zoneless.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (2)
docs/framework/angular/angular-httpclient-and-other-data-fetching-clients.md (2)
14-14
: Link update to stable Zoneless guide looks correct.The new link points to the canonical Zoneless page, and the former experimental path now redirects to it.
References: angular.dev/guide/zoneless and redirect from /guide/experimental/zoneless. (angular.dev)
14-14
: All experimental Zoneless links removed
Ranrg -nP --hidden --glob '!**/node_modules/**' '/guide/experimental/zoneless'
—no matches found.
Angular Zoneless is no longer experimental
Summary by CodeRabbit