test(react-query/useSuspenseQueries): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersByTimeAsync', and add 'expect' using 'toBeInTheDocument'
|
View your CI Pipeline Execution ↗ for commit bdf6688
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9450 +/- ##
===========================================
+ Coverage 45.30% 84.38% +39.07%
===========================================
Files 208 26 -182
Lines 8283 365 -7918
Branches 1865 107 -1758
===========================================
- Hits 3753 308 -3445
+ Misses 4085 48 -4037
+ Partials 445 9 -436 🚀 New features to boost your workflow:
|
…ise-time-advanceTimersByTimeAsync
…ise-time-advanceTimersByTimeAsync
manudeli
reviewed
Jul 20, 2025
| @@ -311,7 +311,7 @@ describe('useSuspenseQueries 2', () => { | |||
|
|
|||
| const { data } = useSuspenseQuery({ | |||
| queryKey: [id], | |||
| queryFn: () => Promise.resolve(`Data ${id}`), | |||
| queryFn: () => sleep(10).then(() => `Data ${id}`), | |||
Comment on lines
-642
to
-649
| await act(() => vi.advanceTimersByTimeAsync(200)) | ||
| rendered.getByText('loading') | ||
| // unmount while still fetching | ||
| expect(rendered.getByText('loading')).toBeInTheDocument() | ||
| fireEvent.click(rendered.getByText('hide')) | ||
| await act(() => vi.advanceTimersByTimeAsync(800)) | ||
| rendered.getByText('page2') | ||
| expect(rendered.getByText('page2')).toBeInTheDocument() | ||
| // wait for query to be resolved | ||
| await act(() => vi.advanceTimersByTimeAsync(2000)) |
manudeli
approved these changes
Jul 20, 2025
sukvvon
commented
Jul 20, 2025
| await sleep(10) | ||
| return 'data' + count | ||
| }, | ||
| queryFn: async () => sleep(10).then(() => 'data' + count), |
There was a problem hiding this comment.
Suggested change
| queryFn: async () => sleep(10).then(() => 'data' + count), | |
| queryFn: () => sleep(10).then(() => 'data' + count), |
There was a problem hiding this comment.
I missed this. I gonna fix this next time
sukvvon
deleted the
test/react-query-useSuspenseQueries-use-precise-time-advanceTimersByTimeAsync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.