test(react-query/useInfiniteQuery): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9446

sukvvon · 2025-07-17T14:27:35Z

No description provided.

…sByTimeAsync', and add 'expect' using 'toBeInTheDocument'

…e-time-advanceTimersByTimeAsync

nx-cloud · 2025-07-17T14:28:09Z

View your CI Pipeline Execution ↗ for commit f2371dd

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	57s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-07-20 03:55:50 UTC

pkg-pr-new · 2025-07-17T14:29:44Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9446

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9446

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9446

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9446

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9446

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9446

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9446

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9446

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9446

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9446

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9446

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9446

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9446

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9446

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9446

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9446

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9446

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9446

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9446

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9446

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9446

commit: f2371dd

codecov · 2025-07-17T14:31:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (05c62a0) to head (f2371dd).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9446       +/-   ##
===========================================
+ Coverage   45.30%   84.38%   +39.07%     
===========================================
  Files         208       26      -182     
  Lines        8283      365     -7918     
  Branches     1869      107     -1762     
===========================================
- Hits         3753      308     -3445     
+ Misses       4085       48     -4037     
+ Partials      445        9      -436

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`95.95% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…e-time-advanceTimersByTimeAsync

manudeli · 2025-07-19T16:06:48Z

packages/react-query/src/__tests__/useInfiniteQuery.test.tsx

@@ -81,7 +81,7 @@ describe('useInfiniteQuery', () => {

    renderWithClient(queryClient, <Page />)

-    await vi.advanceTimersByTimeAsync(100)
+    await vi.advanceTimersByTimeAsync(0)


Suggested change

await vi.advanceTimersByTimeAsync(0)

await vi.advanceTimersByTimeAsync(10)

Could you add queryFn like below

function Page() { const state = useInfiniteQuery({ queryKey: key, queryFn: ({ pageParam }) => sleep(10).then(() => Number(pageParam)), getNextPageParam: (lastPage) => lastPage + 1, initialPageParam: 0, }) states.push(state) return null }

@manudeli

I reflected your opinion. 👍

… states for a successful query case

…sByTimeAsync', and add 'expect' using 'toBeInTheDocument'

manudeli

Much tighter and more realistic now 👍

manudeli · 2025-07-20T03:47:17Z

packages/react-query/src/__tests__/useInfiniteQuery.test.tsx

@@ -1422,7 +1422,7 @@ describe('useInfiniteQuery', () => {
    function Page() {
      const state = useInfiniteQuery({
        queryKey: key,
-        queryFn: ({ pageParam }): number => pageParam,
+        queryFn: ({ pageParam }) => sleep(10).then(() => pageParam),


manudeli · 2025-07-20T03:47:23Z

packages/react-query/src/__tests__/useInfiniteQuery.test.tsx

@@ -1383,7 +1383,7 @@ describe('useInfiniteQuery', () => {
    function Page() {
      const state = useInfiniteQuery({
        queryKey: key,
-        queryFn: ({ pageParam }): number => pageParam,
+        queryFn: ({ pageParam }) => sleep(10).then(() => pageParam),


manudeli · 2025-07-20T03:47:35Z

packages/react-query/src/__tests__/useInfiniteQuery.test.tsx

-    const queryFn = async () => {
-      return Promise.resolve('custom client')
-    }
+    const queryFn = () => sleep(10).then(() => 'custom client')


manudeli · 2025-07-20T03:47:59Z

packages/react-query/src/__tests__/useInfiniteQuery.test.tsx

@@ -335,7 +336,7 @@ describe('useInfiniteQuery', () => {
    function Page() {
      const state = useInfiniteQuery({
        queryKey: key,
-        queryFn: () => ({ count: 1 }),
+        queryFn: () => sleep(10).then(() => ({ count: 1 })),


manudeli · 2025-07-20T03:52:32Z

packages/react-query/src/__tests__/useInfiniteQuery.test.tsx

@@ -71,7 +71,7 @@ describe('useInfiniteQuery', () => {
    function Page() {
      const state = useInfiniteQuery({
        queryKey: key,
-        queryFn: ({ pageParam }) => Number(pageParam),
+        queryFn: ({ pageParam }) => sleep(10).then(() => Number(pageParam)),


Suggested change

queryFn: ({ pageParam }) => sleep(10).then(() => Number(pageParam)),

queryFn: ({ pageParam }) => sleep(10).then(() => pageParam),

https://tanstack.com/query/latest/docs/framework/react/guides/migrating-to-v5#infinite-queries-now-need-a-initialpageparam

This seems to be a leftover from TanStack Query v4! Now, TanStack Query v5 has improved this type of thing and I think this part should be improved incrementally throughout the entire code.
We can remove unnecessary code like this. I would appreciate it if you could take care of this gradually too!

This seems to be a leftover from TanStack Query v4! Now, TanStack Query v5 has improved this type of thing and I think this part should be improved incrementally throughout the entire code. We can remove unnecessary code like this. I would appreciate it if you could take care of this gradually too!

@manudeli

I totally agree with you. I’ll take care of this part as well in future tasks.

…e-time-advanceTimersByTimeAsync

sukvvon added 2 commits July 17, 2025 23:26

test(react-query/useInfiniteQuery): use precise time in 'advanceTimer…

322503e

…sByTimeAsync', and add 'expect' using 'toBeInTheDocument'

Merge branch 'main' into test/react-query-useInfiniteQuery-use-precis…

e71cd8c

…e-time-advanceTimersByTimeAsync

github-actions bot added the package: react-query label Jul 17, 2025

Merge branch 'main' into test/react-query-useInfiniteQuery-use-precis…

267afe9

…e-time-advanceTimersByTimeAsync

manudeli requested changes Jul 19, 2025

View reviewed changes

test(react-query/useInfiniteQuery): add 'sleep' in return the correct…

3e4dc8a

… states for a successful query case

sukvvon requested a review from manudeli July 19, 2025 16:15

sukvvon marked this pull request as draft July 19, 2025 18:05

test(react-query/useInfiniteQuery): use precise time in 'advanceTimer…

afd45f0

…sByTimeAsync', and add 'expect' using 'toBeInTheDocument'

sukvvon marked this pull request as ready for review July 20, 2025 03:44

manudeli approved these changes Jul 20, 2025

View reviewed changes

Merge branch 'main' into test/react-query-useInfiniteQuery-use-precis…

f2371dd

…e-time-advanceTimersByTimeAsync

manudeli merged commit efb14d6 into TanStack:main Jul 20, 2025
7 checks passed

sukvvon deleted the test/react-query-useInfiniteQuery-use-precise-time-advanceTimersByTimeAsync branch July 23, 2025 00:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(react-query/useInfiniteQuery): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9446

test(react-query/useInfiniteQuery): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9446

Uh oh!

sukvvon commented Jul 17, 2025

Uh oh!

nx-cloud bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 17, 2025 •

edited

Loading

Uh oh!

manudeli Jul 19, 2025

Uh oh!

sukvvon Jul 19, 2025

Uh oh!

manudeli left a comment

Uh oh!

manudeli Jul 20, 2025

Uh oh!

manudeli Jul 20, 2025

Uh oh!

manudeli Jul 20, 2025

Uh oh!

manudeli Jul 20, 2025

Uh oh!

manudeli Jul 20, 2025 •

edited

Loading

Uh oh!

sukvvon Jul 20, 2025

Uh oh!

Uh oh!

Uh oh!

	await vi.advanceTimersByTimeAsync(0)
	await vi.advanceTimersByTimeAsync(10)

	queryFn: ({ pageParam }) => sleep(10).then(() => Number(pageParam)),
	queryFn: ({ pageParam }) => sleep(10).then(() => pageParam),

Uh oh!

test(react-query/useInfiniteQuery): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9446

test(react-query/useInfiniteQuery): use precise time in 'advanceTimersByTimeAsync', and add 'expect' using 'toBeInTheDocument' #9446

Uh oh!

Conversation

sukvvon commented Jul 17, 2025

Uh oh!

nx-cloud bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

manudeli Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

sukvvon Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

manudeli left a comment

Choose a reason for hiding this comment

Uh oh!

manudeli Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

manudeli Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

manudeli Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

manudeli Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

manudeli Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sukvvon Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nx-cloud bot commented Jul 17, 2025 •

edited

Loading

pkg-pr-new bot commented Jul 17, 2025 •

edited

Loading

codecov bot commented Jul 17, 2025 •

edited

Loading

manudeli Jul 20, 2025 •

edited

Loading