Skip to content

test(svelte-query/createMutation): remove 'vi.waitFor', and add 'advanceTimersByTimeAsync' #9414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025
Merged

test(svelte-query/createMutation): remove 'vi.waitFor', and add 'advanceTimersByTimeAsync' #9414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e7ff4
test(svelte-query/createMutation): remove 'vi.waitFor', and add 'adva…
sukvvon Jul 12, 2025
530ef7d
Merge branch 'main' into test/svelte-query-createMutation-add-advance…
manudeli Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 27 additions & 58 deletions packages/svelte-query/tests/createMutation/createMutation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,17 @@ describe('createMutation', () => {
test('Able to reset `error`', async () => {
const rendered = render(ResetExample)

await vi.waitFor(() => {
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
})
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))

await vi.waitFor(() => {
expect(
rendered.queryByText('Error: Expected mock error'),
).toBeInTheDocument()
})
await vi.advanceTimersByTimeAsync(0)
expect(
rendered.queryByText('Error: Expected mock error'),
).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Reset/i }))

await vi.waitFor(() => {
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
})
await vi.advanceTimersByTimeAsync(0)
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
})

test('Able to call `onSuccess` and `onSettled` after each successful mutate', async () => {
Expand All @@ -47,29 +41,21 @@ describe('createMutation', () => {
},
})

await vi.waitFor(() => {
expect(rendered.queryByText('Count: 0')).toBeInTheDocument()
})
expect(rendered.queryByText('Count: 0')).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
await vi.advanceTimersByTimeAsync(0)
expect(rendered.queryByText('Count: 3')).toBeInTheDocument()

await vi.waitFor(() => {
expect(rendered.queryByText('Count: 3')).toBeInTheDocument()
})

await vi.waitFor(() => {
expect(onSuccessMock).toHaveBeenCalledTimes(3)
})
expect(onSuccessMock).toHaveBeenCalledTimes(3)

expect(onSuccessMock).toHaveBeenCalledWith(1)
expect(onSuccessMock).toHaveBeenCalledWith(2)
expect(onSuccessMock).toHaveBeenCalledWith(3)

await vi.waitFor(() => {
expect(onSettledMock).toHaveBeenCalledTimes(3)
})
expect(onSettledMock).toHaveBeenCalledTimes(3)

expect(onSettledMock).toHaveBeenCalledWith(1)
expect(onSettledMock).toHaveBeenCalledWith(2)
Expand All @@ -96,41 +82,24 @@ describe('createMutation', () => {
},
})

await vi.waitFor(() =>
expect(rendered.queryByText('Data: undefined')).toBeInTheDocument(),
)
expect(rendered.queryByText('Data: undefined')).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
await vi.waitFor(() =>
expect(rendered.getByText('Data: undefined')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(rendered.getByText('Status: error')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(rendered.getByText('Failure Count: 1')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(
rendered.getByText('Failure Reason: Expected mock error'),
).toBeInTheDocument(),
)
expect(rendered.getByText('Data: undefined')).toBeInTheDocument()
await vi.advanceTimersByTimeAsync(0)
expect(rendered.getByText('Status: error')).toBeInTheDocument()
expect(rendered.getByText('Failure Count: 1')).toBeInTheDocument()
expect(
rendered.getByText('Failure Reason: Expected mock error'),
).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
await vi.waitFor(() =>
expect(rendered.getByText('Status: pending')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(rendered.getByText('Status: success')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(rendered.getByText('Data: 2')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(rendered.getByText('Failure Count: 0')).toBeInTheDocument(),
)
await vi.waitFor(() =>
expect(rendered.getByText('Failure Reason: null')).toBeInTheDocument(),
)
await vi.advanceTimersByTimeAsync(0)
expect(rendered.getByText('Status: pending')).toBeInTheDocument()
await vi.advanceTimersByTimeAsync(6)
expect(rendered.getByText('Status: success')).toBeInTheDocument()
expect(rendered.getByText('Data: 2')).toBeInTheDocument()
expect(rendered.getByText('Failure Count: 0')).toBeInTheDocument()
expect(rendered.getByText('Failure Reason: null')).toBeInTheDocument()
})
})
Loading