[!!!][TASK] CDATA sections remain in templates #1180
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removal of all CDATA sections was introduced with 978071f without any clear indication why this was done. The consequence now is that there is no longer a "parser stop marker", for example for inline CSS interfering with Fluid's inline syntax. Later, this was documented as a "solution" to hide invalid Fluid syntax from the Fluid parser, for example during development. Since `<f:comment>` now works correctly for invalid Fluid, this patch removes the code responsible for removing the CDATA sections from templates. This is a breaking change because templates might have used `CDATA` in the past to comment out code. Resolves: #1012
|
TODO: Deprecate first in 4.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of all CDATA sections was introduced with 978071f without any clear indication why this was done. The consequence now is that there is no longer a "parser stop marker", for example for inline CSS interfering with Fluid's inline syntax.
Later, this was documented as a "solution" to hide invalid Fluid syntax from the Fluid parser, for example during development. Since
<f:comment>now works correctly for invalid Fluid, this patch removes the code responsible for removing the CDATA sections from templates. This is a breaking change because templates might have usedCDATAin the past to comment out code.Resolves: #1012