fix tests by downgrading mime to v1 and locking deps #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File-api uses mime dependency with semver set to >= 1.2.11. Latest mime v2 has breaking changes and requires ES6 support. File-api is not maintained anymore so we cannot add support for mime v2. Having mime v1 in dependencies will satisfy file-api's needs for now.
|
Travis build passes -> https://travis-ci.org/jakubzitny/EvaporateJS/builds/287475771. |
|
Thank you so much @jakubzitny . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR manually adds older mime v1 dependency for
file-apithat we use in tests.I am also adding
yarn.lockandpackage-lock.jsonso locking dependencies works in latestnpmand yarn.