Skip to content

Bad Frozen error messages #1494

@xenoterracide

Description

@xenoterracide

So of course as you already know moving an existing application to a new architecture requires ignoring certain rules. The Frozen rule concept is pretty good. I see two problems though. I would really rather not explain to most people how to freeze new rules because you want them to not constantly try to work around the system.

  1. You can't create the Frozen rule store and then remove the Frozen rule thing to get good error messages. In other words it doesn't just recognize the existing errors automatically.
  2. In order to get good error messages you have to unfreeze the rule which means you have to modify the code to see what the new failure actually is.

This is the stack Trace that I currently get if new violations occur for rules that are frozen.

What I need most out of this ticket is to have the new errors print out exactly the same as they would if the rules weren't Frozen. Only the new errors though.

Updating frozen violations is disabled (enable by configuration freeze.store.default.allowStoreUpdate=true)
com.tngtech.archunit.library.freeze.StoreUpdateFailedException: Updating frozen violations is disabled (enable by configuration freeze.store.default.allowStoreUpdate=true)
at com.tngtech.archunit.library.freeze.TextFileBasedViolationStore.save(TextFileBasedViolationStore.java:144)
at com.tngtech.archunit.library.freeze.FreezingArchRule$ViolationStoreLineBreakAdapter.save(FreezingArchRule.java:277)
at com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStore(FreezingArchRule.java:154)
at com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStoreAndReturnNewViolations(FreezingArchRule.java:146)
at com.tngtech.archunit.library.freeze.FreezingArchRule.evaluate(FreezingArchRule.java:127)
at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:84)
at com.tngtech.archunit.library.freeze.FreezingArchRule.check(FreezingArchRule.java:97)
at 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions