[#12588] Test coverage improvements for GroupedResponsesComponent #13321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonqiu212
reviewed
May 26, 2025
There was a problem hiding this comment.
Hi @ctxsmith25 Thank you for contributing the TEAMMATES! Just a few nits below, but the rest of the PR LGTM!
Comment on lines
+155
to
+167
| it('teamInfo: should return correct team info for GRQ mode', () => { | ||
| component.isGrq = true; | ||
| const teamInfo = component.teamInfo; | ||
| expect(teamInfo['recipient']).toBe('(Team 2)'); | ||
| expect(teamInfo['giver']).toBe('(Team 1)'); | ||
| }); | ||
|
|
||
| it('teamInfo: should return correct team info for RGQ mode', () => { | ||
| component.isGrq = false; | ||
| const teamInfo = component.teamInfo; | ||
| expect(teamInfo['recipient']).toBe('(Team 2)'); | ||
| expect(teamInfo['giver']).toBe('(Team 1)'); | ||
| }); |
There was a problem hiding this comment.
I believe setting isGrq does not impact the results of teamInfo(). Can we combine these 2 test cases?
| allResponses: [emptyTeamResponse], | ||
| }; | ||
| component.responses = [emptyTeamQuestionOutput]; | ||
| component.isGrq = true; |
There was a problem hiding this comment.
Similar to above, setting isGrq does not impact the results. Can we remove this?
| allResponses: [noTeamResponse], | ||
| }; | ||
| component.responses = [noTeamQuestionOutput]; | ||
| component.isGrq = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12588
Increased unit test coverage for GroupedResponsesComponent from 54.17% to 100%.
Added test cases in
src/web/app/components/question-responses/grouped-responses/grouped-responses.component.ts