Refactoring for Unit Test Access Controls

[InfinityTwo]

Part of #12048

Issue

After most of the Unit Test migration in #12048, there are a lot of inconsistencies in access control test methods. This is because we did not migrate the many convenient, abstracted, and commonly used access control test methods from ui/webapi/BaseActionTest.java to sqlui/webapi/BaseActionTest.java.

After merging #13254, all of the access control test methods in BaseActionTest.java have been migrated. Hence, this issue aims to refactor the unit test access controls to use these convenient test methods.

Progress

The progress for this refactoring can be found here. I (the author) will update it when completed PRs are merged proactively.

Steps to Contribute

1. Choose test(s) to work on in the above Google Sheets link
2. Check that no on else have claimed the test cases to work on within the last 2 weeks, or that it has been completed by follow up PRs (but not updated in the sheets)
3. Comment on this issue to indicate that you'd like to contribute on the chosen test(s). Update your comment if you need more than 2 weeks so that other contributors don't overlap with your work.
4. Create a PR to refactor the unit test(s).
5. Submit the PR, with a link to this issue by starting the description with "Part of Refactoring for Unit Test Access Controls #13304".
6. Tag me or any other active reviewers and wait for us to review (so that we can get a notification)

Tips

• Understand the access control test methods in sqlui/webapi/BaseActionTest.java, follow the refactoring in [#12048] Abstract Access Controls to BaseActionTest #13254
• Most of the access control testing logic in the migrated unit tests under sqlui/webapi follows the old unit tests under ui/webapi, so you may wish to reference the old unit test for help

[github-actions]

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

[alextlucas]

Hello, I'm new to teammates and would like to take this as my first issue.

[InfinityTwo]

Hello, I'm new to teammates and would like to take this as my first issue.

Hi @alextlucas, thanks for wanting to contribute. I would like to suggest that you can consider waiting for my PR to be merged before tackling as there might still be changes after reviews on my PR. Also, do comment which tests you would like to contribute to so that it does not conflict with other developers who wish to contribute as well 😄

[alextlucas]

@InfinityTwo Sounds good, I will subscribe to the PR and wait for the merge. I can work on rows 38-48 to start, and do more if needed.

[matheusknaul]

Hello.
How are you?
I'm new to Teammates and I'm very excited to contribute to the project!
Since Lucas has already requested lines 38-48, can I start from there? Taking 49 to 59?

[arnav-goel05]

Hey @InfinityTwo, would love to contribute to this issue! Was wondering whether I could work on lines 60 to 70?

[InfinityTwo]

Hey interested contributors, thanks for your interest and want to help! Feel free to work on whichever rows you want, no permission is required from me. All I ask for is to state which rows you intend to touch on and avoid clashing with others, by giving a 1-2 week grace period. If there are no subsequent PRs linked to this issue within that time, you may tag the previous user who claimed it know you are taking over if you would like to tackle it.

[zedonggg]

Hi, since the other rows have already been taken, I'd be keen to do lines 71-78. Thank you!

[matheusknaul]

Hi @InfinityTwo, I'm working on lines 49-59.