ST6RI-883 Implicit specializations missing for individual definitions #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug that caused implicit specializations not to be added for an individual definition declared as anything more specific than an occurrence definition. Such a definition gets an implicit specialization of
Occurrences::Life, as required, but previously it did not get an implied specialization for the more specific kind of thing that it is. For example,resulted in the error “Must directly or indirectly specialize Items::Item”, because it was not being given the necessary implicit specialization of
Items::Item. (Note that this error was avoided in the common case of the individual item definition specializing another non-individual item definition that already specializesItems::Item,)The bug was caused because, when an occurrence definition was an individual definition, the
OccurrenceDefinitionAdapteradded an implicit specialization toLifeinstead of the normalbasedefinition, rather than in addition to it. This PR corrects that.