ST6RI-843 Annotate adapter transformation code with implemented semantic constraints #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Semantic constraints marked from SysmlV2 abstract syntax from 8.3.6.2 to 8.3.16.13
@Satisfies for: - checkMultiplicityRangeExpressionTypeFeaturing - checkUsageVariationUsageTypeFeaturing - checkMetadataFeatureSemanticSpecialization - checkFeatureChainExpressionResultSpecialization - checkFeatureResultRedefinition - checkFeatureEndRedefinition TODOs for: - checkDescisionNodeOutgoingSuccessionSpecialization - checkMergeNodeIncomingSuccessionSpecialization
TheKorpos
reviewed
Jul 3, 2025
Contributor
TheKorpos
left a comment
TheKorpos
left a comment
There was a problem hiding this comment.
@seidewitz
Thank you for annotating the remaining semantic constraints. I compared them to the OCLs and commented on two of them that might be off.
org.omg.sysml/src/org/omg/sysml/adapter/FeatureChainExpressionAdapter.java
Show resolved
Hide resolved
- ConnectorUsageAdapter - ViewUsageAdapter - RenderingUsageAdapter
- This is where checkTransitionUsagePayload Specialization is satisfied.
ST6RI-857/858/860/861 Semantic transformation bugs
TheKorpos
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds annotations to the code to identify the implementation of transformations that satisfy various semantic constraints from the KerML and SysML specifications. These annotations have the following form:
@satisfiesconstraintName– The annotated code implements a transformation to satisfy the named semantic constraint.In addition, comments have been included in the constructor for
ImplicitGeneralizationMapto indicate which specialization constraints are satisfied by the various implicit specializations in the map.The PR also adds annotations to identify were the current implementation differs from the specifications and semantic constraints that are not yet implemented. These annotations have one of the following forms:
TODO: UpdateconstraintName– The specification of the named constraints should be updated to be consistent with the implementation. A reference is also provided to a KerML 1.1 or SysML 2.1 Revision Task Force issue addressing this.TODO:constraintName– There is currently no implementation for the named constraint.