Skip to content

Implement compiler pass from bundle extension #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Open

Implement compiler pass from bundle extension #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/DependencyInjection/SyliusThemeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,27 @@

namespace Sylius\Bundle\ThemeBundle\DependencyInjection;

use Sylius\Bundle\ThemeBundle\Asset\Package\PathPackage;
use Sylius\Bundle\ThemeBundle\Asset\PathResolverInterface;
use Sylius\Bundle\ThemeBundle\Configuration\ConfigurationProviderInterface;
use Sylius\Bundle\ThemeBundle\Configuration\ConfigurationSourceFactoryInterface;
use Sylius\Bundle\ThemeBundle\Context\ThemeContextInterface;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\Argument\AbstractArgument;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Extension\Extension;
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
use Symfony\Component\DependencyInjection\Reference;

final class SyliusThemeExtension extends Extension
final class SyliusThemeExtension extends Extension implements CompilerPassInterface
{
/** @var ConfigurationSourceFactoryInterface[] */
private array $configurationSourceFactories = [];

private bool $overrideAssetsPathPackage = false;

/**
* @internal
*/
Expand All @@ -37,6 +45,7 @@ public function load(array $configs, ContainerBuilder $container): void

if ($config['assets']['enabled']) {
$loader->load('services/integrations/assets.xml');
$this->overrideAssetsPathPackage = true;

if ($config['legacy_mode']) {
$loader->load('services/integrations/legacy_assets.xml');
Expand Down Expand Up @@ -101,4 +110,21 @@ private function resolveConfigurationSources(ContainerBuilder $container, array
$container->addObjectResource($configurationSourceFactory);
}
}

public function process(ContainerBuilder $container)
{
if ($this->overrideAssetsPathPackage) {
$assetsPathPackageDefinition = new Definition('assets.path_package');
$assetsPathPackageDefinition
->setClass(PathPackage::class)
->setAbstract(true)
->addArgument(new AbstractArgument('base path'))
->addArgument(new AbstractArgument('version strategy'))
->addArgument(new Reference(ThemeContextInterface::class))
->addArgument(new Reference(PathResolverInterface::class))
->addArgument(new Reference('assets.context'))
;
$container->setDefinition('assets.path_package', $assetsPathPackageDefinition);
}
}
}
9 changes: 0 additions & 9 deletions src/Resources/config/services/integrations/assets.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,5 @@
<argument type="service" id="kernel" />
<argument type="service" id="Sylius\Bundle\ThemeBundle\HierarchyProvider\ThemeHierarchyProviderInterface" />
</service>

<!-- Overridden services -->
<service id="assets.path_package" class="Sylius\Bundle\ThemeBundle\Asset\Package\PathPackage" abstract="true">
<argument /> <!-- base path -->
<argument /> <!-- version strategy -->
<argument type="service" id="Sylius\Bundle\ThemeBundle\Context\ThemeContextInterface" />
<argument type="service" id="Sylius\Bundle\ThemeBundle\Asset\PathResolverInterface" />
<argument type="service" id="assets.context" />
</service>
</services>
</container>