[Bug] Default Payment Method

[migo315]

SyliusPayPalPlugin version affected: 1.6.0

Description
Our customers can set their preferred payment method as the default payment method. We have written the code for this ourselves.

However, this conflicts with the PayPal Express Checkout, as it seems to assume that PayPal is always the default payment method. The checkout fails.

Steps to reproduce

• Set payment in the current shopping cart to a payment method other than ‘PayPal’ (via the database)
• Try PayPal Express Checkout

Possible Solution
Modify the CreatePayPalOrderFromCartAction so that the payment method is changed to PayPal?

[tomkalon]

The concept of a "default payment method selected by customers" doesn't exist in out-of-the-box Sylius — it would need to be implemented at the project level.

The PayPal plugin is designed to integrate with the standard Sylius checkout flow and doesn't account for custom overrides of payment selection logic.

In such cases, we recommend adjusting the plugin behavior (e.g., via a decorator for CreatePayPalOrderFromCartAction) to accommodate your custom logic.

[migo315]

I’m aware that a "default payment method selected by customers" needs to be implemented at the project level — that’s not the point I was raising. I only mentioned it for context.

My actual concern is that Sylius does provide an implementation (DefaultPaymentMethodResolverInterface) that allows projects to change this behavior, but the PayPal plugin completely breaks it. My expectation would be that the PayPal plugin is robust enough to still work without errors when a project implements its own DefaultPaymentMethodResolverInterface. But that’s exactly what it doesn’t do. It surely can’t be the intended behavior that the plugin only works properly when PayPal happens to be the very first payment method.

Just to clarify: I have no problem with the PayPal plugin changing the order of payment methods. But it must be able to handle the situation where, for whatever reason, it’s not the first choice.

[Renrhaf]

I was facing a similar issue as I had ordered payment methods in the way I wanted in the backoffice with positions.
Then I noticed that PayPal was coming first all the time. The easy solution for me was to disable the responsible decorator (PayPalPrioritisingPaymentMethodsResolver) like that :

services:
    ... 
    sylius_paypal.resolver.payment_method.paypal_prioritising:
        class: stdClass