SYL-4341 Remove documentation links #74
Conversation
tests/Application/templates/bundles/SyliusAdminBundle/PaymentMethod/_form.html.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I wonder if adding this macro makes sense, as these keys are used once 🤔
There was a problem hiding this comment.
Why not just create form_theme for each field and set the links in there?
Then we don't have to if into oblivion, but have a block per case
GSadee
added
Admin
| @@ -1,12 +1,20 @@ | |||
| {% import '@SyliusAdmin/PaymentMethod/_documentation_helpers.html.twig' as doc %} | |||
There was a problem hiding this comment.
| {% import '@SyliusAdmin/PaymentMethod/_documentation_helpers.html.twig' as doc %} | |
| {% import '@SyliusMolliePlugin/Admin/PaymentMethod/_documentation_helpers.html.twig' as doc %} |
Custom templates should live in the app
There was a problem hiding this comment.
Maybe we should move it to a new PR, since there are many more like this here—it might be better to handle all of them at once. What do you think?
There was a problem hiding this comment.
Why not just create form_theme for each field and set the links in there?
Then we don't have to if into oblivion, but have a block per case
Cholin2000
force-pushed
the
Remove-mollie-documentation-links
branch
from
7ca1764 to
f2213e1
Compare
tests/Application/templates/bundles/SyliusAdminBundle/PaymentMethod/_form.html.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Newly added templates should be added to the proper plugin templates directory, the others could be refactored in a separate PR. Could you open such a PR after merging this one? 🤔
...ation/templates/bundles/SyliusAdminBundle/PaymentMethod/_mollie_gateway_help_theme.html.twig
Outdated
Show resolved
Hide resolved
tests/Application/templates/bundles/SyliusAdminBundle/PaymentMethod/_form.html.twig
Outdated
Show resolved
Hide resolved
Task: https://sylius.atlassian.net/browse/SYL-4341