Skip to content

[Maintenance] Refactor Options classes and usage #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 27, 2025
Merged

[Maintenance] Refactor Options classes and usage #59

merged 8 commits into from
Mar 27, 2025

Conversation

NoResponseMate
Copy link
Collaborator

No description provided.

@NoResponseMate NoResponseMate added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Mar 26, 2025
@NoResponseMate NoResponseMate marked this pull request as ready for review March 26, 2025 11:55
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add notes about these changes to the UPGRADE file

Comment on lines +36 to +37
'sylius_mollie_plugin.ui.paymentlink' => TemplateMollieEmailInterface::PAYMENT_LINK,
'sylius_mollie_plugin.ui.paymentlinkAbandoned' => TemplateMollieEmailInterface::PAYMENT_LINK_ABANDONED,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'sylius_mollie_plugin.ui.paymentlink' => TemplateMollieEmailInterface::PAYMENT_LINK,
'sylius_mollie_plugin.ui.paymentlinkAbandoned' => TemplateMollieEmailInterface::PAYMENT_LINK_ABANDONED,
'sylius_mollie_plugin.ui.payment_link' => TemplateMollieEmailInterface::PAYMENT_LINK,
'sylius_mollie_plugin.ui.payment_link_abandoned' => TemplateMollieEmailInterface::PAYMENT_LINK_ABANDONED,

@GSadee GSadee merged commit 1b1f71b into Sylius:2.0 Mar 27, 2025
3 checks passed
@GSadee GSadee deleted the SYL-4343/refactor-options branch March 27, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants