This repository was archived by the owner on Oct 17, 2021. It is now read-only.
Improve node traversal options (and more tweaks) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrosjean
changed the title
jessegrosjean
changed the title
mattt
approved these changes
Oct 17, 2021
Contributor
mattt
left a comment
mattt
left a comment
There was a problem hiding this comment.
Thanks so much for this, @jessegrosjean. Sorry for not reviewing it sooner. 🙇
I'll merge this in now and make it available in a new release.
Contributor
|
This is now available in version 0.1.3. Thanks again, @jessegrosjean! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise I was seeing crash on node.next/previous when the value was nil pointer.