Skip to content

feat: Delete trino credential after expiration #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 21, 2025

Conversation

Gayathri-Menon
Copy link
Collaborator

🚧 Suggest a change

A clear and concise description of what you are changing.

📝 Pre-merge checklist

Ready to merge? Do not merge until all checks are satisfied.

  • 💹 Have all required CI checks passed on the most recent commit?
  • ✒️ Is the PR title a valid and meaningful conventional-commit message? ie. type(scope): summary
  • 💥 Are breaking changes declared in the PR title in conventional-commit style? ie. type!(scope): summary
  • 🎨 Does new code follow the code style of this project?
  • 🔍 Has new code been spellchecked and linted?
  • 📖 Have docs been updated where necessary?
  • 💩 Have commits been checked for accidental file inclusions?

Copy link

✒️ PR Title Commitlint - ✔️ Lint success!

Copy link
Collaborator

@LockhartJones LockhartJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the expiration time period is for as the timers in camunda will control when the service needs to expire and move onto the Remove Trino task

@Gayathri-Menon
Copy link
Collaborator Author

Have removed expiration period changes from the PR after discussion

@Gayathri-Menon Gayathri-Menon merged commit f99dd31 into main Aug 21, 2025
19 checks passed
@Gayathri-Menon Gayathri-Menon deleted the feat/deletetrinocred branch August 21, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants