fix: port number git remote link #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAKURA-CAT
approved these changes
Mar 11, 2025
SAKURA-CAT
added
🐛 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
修复了在带端口号的http git链接下，会把端口号的冒号替换成'/'的问题
This pull request includes changes to the
get_remote_urlfunction in theswanlab/data/run/metadata/runtime.pyfile to improve URL handling for git repositories. The most important changes include modifying the URL conversion logic and updating thereplace_second_colonfunction.Improvements to URL handling:
swanlab/data/run/metadata/runtime.py: Modified theget_remote_urlfunction to convert SSH URLs to HTTPS and remove the.gitsuffix without callingreplace_second_colonunnecessarily.swanlab/data/run/metadata/runtime.py: Updated thereplace_second_colonfunction's docstring to use the correct character encoding for the colon symbol.