feat: sync enhancement #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAKURA-CAT
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several enhancements and refactorings to the
swanlab/syncmodule, specifically targeting the tensorboard and wandb synchronization functionalities. The changes introduce a common utility function for extracting arguments and add support for additional tensorboard methods.Enhancements to argument extraction:
swanlab/sync/tensorboard.py: Added_extract_argsfunction to extract parameters fromargsandkwargsin a consistent manner.swanlab/sync/wandb.py: Added_extract_argsfunction to extract parameters fromargsandkwargsin a consistent manner.Enhancements to tensorboard synchronization:
swanlab/sync/tensorboard.py: Modifiedpatched_initto use_extract_argsfor extracting parameters and added support foradd_imagemethod with proper handling of different image formats. [1] [2] [3] [4] [5] [6]Enhancements to wandb synchronization:
swanlab/sync/wandb.py: Modifiedpatched_initandpatched_config_updateto use_extract_argsfor extracting parameters and added support forlogmethod with filtering of non-scalar types. [1] [2] [3]Updates to tests:
test/sync_tensorboardX.py: Added test foradd_imagemethod to validate the new functionality.test/sync_tensorboard_torch.py: Added test foradd_imagemethod to validate the new functionality.test/sync_wandb.py: Modified test to includenotesparameter and update configuration to validate the new functionality.