-
Notifications
You must be signed in to change notification settings - Fork 151
use swankit #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
use swankit #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b68461.
将媒体处理改为可选依赖
Merged
contribute没啥问题,等 @Feudalman 看看? |
Zeyi-Lin
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
swanlab全面接入swankit,功能解藕,环境变量明确,测试脚本重构。
将媒体类型处理改为可选依赖 #633
更新了贡献文档 #634
功能解藕
log、callback和部分共享环境变量存放在swankit包中,作为基础开发工具的一部分
环境变量明确
删除了原本十分麻烦的的环境变量记忆功能,仅保留部分有用的环境变量,现在所有的环境变量通过api动态计算
测试脚本重构
对于测试,删除了原本的config.json文件,并且增加了对.env环境变量的配置依赖。在项目根目录下创建
.env
文件,写入如下内容:如果你不想进行云端部分业务的测试,可以填入:
此时
TEST_CLOUD_KEY
不再有用,参考CONTRIBUTING.md
文件内描述。此外,
package.mock.json
文件被移到了项目根目录下。