Skip to content

fix: delete charts with experiment destroying #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: delete charts with experiment destroying #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions swanlab/server/controller/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
Experiment,
Chart,
Namespace,
Tag,
)

__to_list = Experiment.search2list
Expand Down Expand Up @@ -553,8 +554,22 @@ def delete_experiment(experiment_id: int):
# 先删除实验目录
experiment_path = __get_exp_dir_by_id(experiment_id)
shutil.rmtree(experiment_path)
# 再清除数据库中的实验数据
Experiment.delete().where(Experiment.id == experiment_id).execute()
# 看看该实验下有哪儿些 tag
tags = Tag.filter(Tag.experiment_id == experiment_id)
tag_names = [tag["name"] for tag in __to_list(tags)]
# 检查多实验图表是否有需要删除的
project_id = Experiment.get_by_id(experiment_id).project_id.id
charts = Chart.filter(Chart.project_id == project_id, Chart.name.in_(tag_names))

db = connect()
with db.atomic():
# 必须先清除数据库中的实验数据
Experiment.delete().where(Experiment.id == experiment_id).execute()
# 图表无 source 的需要删除
for chart in charts:
if len(chart.sources) == 0:
chart.delete().execute()
db.commit()

return SUCCESS_200({"experiment_id": experiment_id})

Expand Down