chore: opt retry params #1258
Merged
chore: opt retry params #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raised the total HTTP retry attempts from 3 to 10 and increased the backoff factor to 0.5 in the Client class. Updated the corresponding unit test to match the new retry logic and simplified response assertions.
Zeyi-Lin
approved these changes
Sep 9, 2025
Moved session creation with retry mechanism to a new create_session utility in swanlab/core_python/session.py. Updated client and auth modules to use this shared session logic. Added unit tests for session retry behavior and removed redundant retry test from test_client.py.
Moved session creation logic with retry and custom headers to a shared create_session function in swanlab.core_python.session. Updated ApiHTTP to use this function. Added unit tests to verify session headers and header merging behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised the total HTTP retry attempts from 3 to 10 and increased the backoff factor to 0.5 in the Client class. Updated the corresponding unit test to match the new retry logic and simplified response assertions.
for: #1252