feat: swanlab offline, online, local, disabled command #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAKURA-CAT
force-pushed
the
feat/swanlab-offline-command
branch
from
0bec0bf to
a253519
Compare
Introduces FolderSettings for reading and writing INI-based configuration at the folder level, with validation for the mode field. Updates mode initialization logic to prioritize: explicit argument > environment variable > folder settings > default. Adds and extends tests to cover folder settings, mode priority, and error handling for configuration files.
Removed individual mode command files (disabled, local, offline, online) and consolidated their logic into swanlab/cli/commands/mode/__init__.py. Updated imports and CLI registration to use the new module. Centralized swanlog directory creation and settings writing logic in env.py and swanlab_settings, improving maintainability and reducing code duplication.
Changed create_swanlog_dir to accept None as default and defer get_swanlog_dir evaluation. Added extensive unit tests for directory creation, .gitignore handling, permission errors, parameter types, and edge cases to improve reliability and coverage.
Introduces a test to verify that when the user-provided logdir differs from the environment variable, settings are read from the environment variable as expected.
|
offline 等 cli 的写入规则为： 只受环境变量控制，比如用户在环境变量设置 |
SAKURA-CAT
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1198
swanlab offline swanlab online swanlab local swanlab disabled执行上述任一命令，会在
swanlog目录下写入一个settings文件，用于保证在此目录下，未来的实验运行均符合规则。