Skip to content

Conversation

SAKURA-CAT
Copy link
Member

@SAKURA-CAT SAKURA-CAT commented Dec 29, 2023

Description

This PR addresses some issues and introduces swanlab.BaseType to meet future requirements.

@SAKURA-CAT SAKURA-CAT added 🐛 bug Something isn't working 💪 enhancement New feature or request labels Dec 29, 2023
@SAKURA-CAT SAKURA-CAT requested a review from Zeyi-Lin December 29, 2023 07:41
@SAKURA-CAT SAKURA-CAT self-assigned this Dec 29, 2023
@SAKURA-CAT
Copy link
Member Author

please check this @xiaolin199912

@SAKURA-CAT SAKURA-CAT requested a review from Feudalman December 29, 2023 09:11
@Zeyi-Lin Zeyi-Lin marked this pull request as ready for review December 29, 2023 14:57
@Zeyi-Lin
Copy link
Member

@SAKURA-CAT
Copy link
Member Author

SAKURA-CAT commented Dec 29, 2023

第三个你要求的过于细了,代码不是能要求这么写的

@SAKURA-CAT SAKURA-CAT merged commit 9fa38a1 into main Dec 30, 2023
@SAKURA-CAT SAKURA-CAT deleted the fixbug/type-check branch December 30, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working 💪 enhancement New feature or request

Projects

None yet

3 participants