chore: change step duplicate log level #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the log level for duplicate-step notifications from warning to debug, reducing noise in the logs when a step is re-registered.
- Changed
swanlog.warningtoswanlog.debugfor duplicate-step detection. - No functional behavior changes beyond logging verbosity.
Comments suppressed due to low confidence (1)
swanlab/data/run/exp.py:78
- Update or add tests to verify that duplicate-step logging now uses
debuglevel instead ofwarning, ensuring existing tests that expect a warning are updated accordingly.
swanlog.debug(f"Step {step} on key {key} already exists, ignored.")
Feudalman
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1025