Fix plot_intensities
for data on very large grids
#379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very large grid passed to
Makie.image
orMakie.heatmap
causes certain OpenGL backends to fail. Consequently,plot_intensities
will not render certain data.As discussed in MakieOrg/Makie.jl#4950, a workaround is to convert all uses of
Makie.image
toMakie.heatmap
, and then wrap the grid data inside aMakie.Resampler
object. That is implemented here.Notes:
Makie.image
could be preferable overMakie.heatmap
in other ways, e.g., data on a regular grid is faster to render. However, the two have some subtle rendering differences: axis ranges may change slightly, andheatmap
does not interpolate between grid points likeimage
seems to.Makie.Resampler
if that threshold is reached.ylims
argument. With this PR, it is interpreted to apply after any energy units conversions are performed.heatmap
toimage
) happened in Powder averaging of static intensities #374, which this PR partially undoes.