Rename hidden axisopt keyword argument to axis
#378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with Makie conventions: https://docs.makie.org/v0.22/explanations/plot_method_signatures#Special-Keyword-Arguments The argument is hidden, and not currently used in any of the tutorials, so hopefully it won't break user scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
axisfor a dict-like set ofMakie.Axisconfiguration options is consistent with Makie conventions:https://docs.makie.org/v0.22/explanations/plot_method_signatures#Special-Keyword-Arguments
The argument
axisoptwas hidden and not used in any of the tutorials, so this change seems to be non-breaking.