Skip to content

Remove arbitrary-dimension lattices and systems #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

ColeMiles
Copy link
Contributor

@ColeMiles ColeMiles commented Jan 26, 2022

This PR removes the arbitrary-dimensionality functionality of many types throughout Sunny, as some components were effectively locking the dimensionality to 3 anyway. Additionally, 1D + 2D simulations can easily still be performed in the 3D framework, and nobody wants to do >3D simulations.

Effectively, three type parameters can be removed from many types throughout Sunny, and the dimensionality of many arrays is now fixed and statically known. This should buy us some budget for complexity when we inevitably need to add more type parameters for SU(N) simulations.

We also can remove OnSiteQuadratic, which only existed in the first place to dodge an awkward unknown-dimensionality problem we previously had.

@ColeMiles ColeMiles requested a review from kbarros January 26, 2022 08:13
@ColeMiles
Copy link
Contributor Author

Note: There is some code throughout Sunny (particularly in StructureFactors.jl) which is written in a way such that it works for arbitrary-dimension input arrays. All of the code still works after this PR, but could maybe be re-written more simply since we know we're fixing 3D.

Copy link
Member

@kbarros kbarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Cole!

@ColeMiles ColeMiles merged commit 92f3a77 into main Jan 26, 2022
@ColeMiles ColeMiles deleted the remove-gen-d branch January 26, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants