Skip to content

Conversation

akhil-sumologic
Copy link
Collaborator

No description provided.

@akhil-sumologic akhil-sumologic requested a review from a team as a code owner September 3, 2025 11:40
@sumoanema sumoanema requested a review from Copilot September 4, 2025 06:20
Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes various issues in the testsuite including correcting a typo, improving documentation formatting, and enhancing test cleanup procedures.

  • Fixed a spelling error in a comment ("scenerio" → "scenario")
  • Updated README files with improved formatting and increased test timeouts
  • Added cleanup functionality to remove local Terraform state files after test execution

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
aws-observability-terraform/test/sourcemodule/source_test.go Fixed spelling error in comment
aws-observability-terraform/test/sourcemodule/README.md Improved formatting and increased test timeout
aws-observability-terraform/test/appmodule/terraform.go Added cleanup logic to remove local state files
aws-observability-terraform/test/appmodule/README.md Improved formatting and increased test timeout

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- Run following command to execute all Test functions, with function name pattern as Test*
```go test -v -timeout 100m ./test/sourcemodule```
For single Terratest case
``go test -v -timeout 20m ./test/sourcemodule -run ^TestSourceModule1$``
Copy link
Preview

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block uses incorrect backticks. It should use triple backticks for proper markdown formatting like the previous example.

Suggested change
``go test -v -timeout 20m ./test/sourcemodule -run ^TestSourceModule1$``
```go test -v -timeout 20m ./test/sourcemodule -run ^TestSourceModule1$```

Copilot uses AI. Check for mistakes.

Copy link
Contributor

@sumoanema sumoanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhil-sumologic akhil-sumologic merged commit 30e2c96 into fy26q3 Sep 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants