Skip to content

Allowance fields should not be integers #1

@szmija

Description

@szmija

Currently Allowance.cost and Allowance.remaining are both of type long. According to the documentation (https://docs.cryptowat.ch/rest-api/rate-limit), credit cost per API call is never higher than 0.01. This makes Allowance.cost always equal to zero and thus completely useless. Allowance.remaining is also much less useful when rounded to full credits.

I would recommend using another data type instead (decimal or at least double/float) or multiply cost/remaining values returned by Cryptowatch by 1000 before casting them to long, and document those values as milli-credits.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions