Fix bug with SendExtAcknowledgedDataAsync #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated various project files to target .NET 9.0 frameworks, including net9.0, net9.0-android, net9.0-windows10.0.26100.0, and net9.0-windows10.0.19041.0. Upgraded package versions across multiple projects, including Microsoft.Extensions.Hosting, Microsoft.Maui.Core, CommunityToolkit.Mvvm, Serilog.Extensions.Hosting, Serilog.Extensions.Logging, Google.Protobuf, Grpc.Net.Client, Grpc.Tools, and others. Replaced MSTest with xUnit in unit test projects.
The test framework has been switched from MSTest to xUnit. This includes: - Replacing `[TestClass]` with the class declaration. - Replacing `[TestInitialize]` with the class constructor. - Replacing `[TestMethod]` with `[Fact]` and `[DataRow]` with `[Theory]` and `[InlineData]`. - Updating `Assert` methods to xUnit equivalents. - Changing `Mock` objects to `readonly` fields. - Simplifying array initializations using array literals. - Updating `using` directives to include xUnit.
Updated array instantiation to use Array.Empty<T>() instead of new T[0] or new object[] {}. This change affects various method calls and test setups, including Dispose, SendAcknowledgedData, SendAcknowledgedDataAsync, SendBroadcastData, SendBurstTransfer, SendBurstTransferAsync, SendExtAcknowledgedData, SendExtBroadcastData, SendExtBurstTransfer, and SendExtBurstTransferAsync. Also updated the data initialization and method invocation in SendExtAcknowledgedDataAsync_InvokesMethodMultipleTimesAndReturnsPass.
Replaced Frame elements with Border elements across multiple XAML files, updating properties such as BorderColor to Stroke, and adding Margin, Padding, and StrokeShape properties. Updated bindings to include x:DataType=RadioButton and x:DataType=Entry where applicable. Added event handlers and updated command parameter bindings in HomePage.xaml and HomePage.xaml.cs. Updated byte array initialization syntax in BicyclePowerViewModel.cs.
Updated log message formatting for consistency in `SendMessageChannel.cs` and added logging for timeout results. Enhanced logging configuration in `MauiProgram.cs` to set minimum level to Debug in DEBUG mode.
Updated logging in SendMessageChannel.cs to remove Task ID from debug messages, focusing on busy flags and channel index. Added Serilog and its extensions to MauiAntGrpcClient.csproj for enhanced logging capabilities. Replaced the existing logging framework with Serilog in MauiProgram.cs, initializing it early and modifying the debug logging configuration to utilize Serilog.
- Incremented assembly versions for Hosting (1.1.2.0) and AntPlus (5.0.1.0). - Updated package release notes to reflect bug fixes related to ANT radio hardware. - Added new version entries in AntPlus and Hosting Extensions version history files. - Updated ContentLayout to include new version 5.0.1.0 and change visibility for version 3.1.0.0. - Modified Documentation.shfbproj to reference new versions. - Created new XML files for version 5.0.1.0 and 1.1.2.0 with detailed release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
Bug fix and code cleanup.
PR Summary
This pull request updates the project to improve logging, enhance test structure, and increment version numbers for various components. Key changes include:
Hosting.csproj: Updated package release notes and incremented assembly version to1.1.2.0.SendMessageChannel.cs: Improved logging clarity and added timeout handling for ANT channel data transmission.AntDeviceCollectionTests.cs,BicyclePowerTests.cs): Replaced MSTest attributes with xUnit attributes and updated assertions for consistency.AntPlus.csproj: Updated package references to newer versions, includingCommunityToolkit.Mvvm.GeocacheTests.cs: Enhanced parsing and validation of geocache data with improved assertions.Closes ANT message is retained in ANT radio channel hardware after timeout attempting to send message #39