-
Notifications
You must be signed in to change notification settings - Fork 191
[Bugfix] Check label state if fail to commit because FE restarts #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlfjcg
approved these changes
Mar 3, 2023
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
…rRocks#195) Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
…rRocks#195) Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
…rRocks#195) Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
…rRocks#195) Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
…rRocks#195) Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Problem Summary(Required) :
The case is:
label1
label1
, but FE returns a failed status with error message likeUserException: transaction with op commit label 154968ac-c52b-4ae9-8fdf-1df64f285b96 has no backend
(see TransactionLoadAction#executeTransaction for details)The solution is that check label state if commit failed no matter what reason. If the label state is
COMMITTED
orVISIBLE
, the commit should be successful. This can reduce the dependency for the behavior of StarRocksAdditionally, this PR improves some error messages.
Checklist: