#3665 fixing datastore inconsistency issues with #6342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
system scoped keys
pull-request-size
bot
added
the
size/M
|
Test failures seem completely unrelated to the change made. One is a failure to dispose of a sensor and another failed test is due to RMQ channel missing. |
guzzijones
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT:
This PR updates the get_all method of API V1 KeyValue controller so that if it's called by a non-admin user, instead of iterating over a list of keys that the user has access to and fetching them one by one, we fetch them in the same way as if we were an admin and then only add those to the output that the user has access to.
WHY:
This makes it so that the 'prefix' and 'name' filters are honoured even before we only return keys that the user has access to. This should also correct the st2client behaviour that throws an error when calling get_key_by_name (or whatever the name of the method is), as that one does a call to keys?name=key_name instead of keys/key_name.
Fixes #6335