BUG: Output better "version" string when running main.go directly #3658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go has different semantics when you run with `go run .` vs `go run
main.go`.
In the former case, Go provides information about the module, including
some version info. If the tree is not on a semver tag, it outputs
"(devel)".
In the latter case, Go provides no information about the module and
running `go run main.go version` would output a blank line.
The getVersion function from build/build.go has been factored out to the
version package, and simplified to use `git describe` instead of the
multi-step `git rev-parse` and `git diff-index`. Where this previously
output the version as
<sha>[dirty]
It now outputs it as
<last tag>-<num commits since tag>-<short sha>
Optionally with a trailing -dirty.
The -sha flag has been removed from build.go as we get the information
directly from git.
tlimoncelli
approved these changes
Jul 9, 2025
|
Awesome! This is a big improvement and will help clarify things when bugs are reported. Thanks! |
tlimoncelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go has different semantics when you run with
go run .vsgo run main.go.In the former case, Go provides information about the module, including some version info. If the tree is not on a semver tag, it outputs "(devel)".
In the latter case, Go provides no information about the module and running
go run main.go versionwould output a blank line.The getVersion function from build/build.go has been factored out to the version package, and simplified to use
git describeinstead of the multi-stepgit rev-parseandgit diff-index. Where this previously output the version asIt now outputs it as
Optionally with a trailing -dirty.
The -sha flag has been removed from build.go as we get the information directly from git.