BUG: User-Agent should include DNSControl version #3653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9873f9f (v4.7.4) removed the version package in favour of using GoReleaser to set the version, which it only sets in main and is not passed down to other packages. This means that if any other package, notably two providers which use the version for setting a User-Agent, wants access to the version, they no longer have it. This change reintroduces the version package, setting GoReleaser to set the version here, and refactors all uses of the version to use the package. Note that if you run `go run main.go version` the version output by Go for the main module is "(devel)". Using build/build.go gives the commit hash.
tlimoncelli
changed the title
|
After I merged this I realized that "go run main.go version" outputs a blank line. Can you double-check and submit a PR if that's a bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9873f9f (v4.7.4) removed the version package in favour of using GoReleaser to set the version, which it only sets in main and is not passed down to other packages.
This means that if any other package, notably two providers which use the version for setting a User-Agent, wants access to the version, they no longer have it.
This change reintroduces the version package, setting GoReleaser to set the version here, and refactors all uses of the version to use the package.
Note that if you run
go run main.go versionthe version output by Go for the main module is "(devel)". Using build/build.go gives the commit hash.Fixes #3651