Skip to content

Conversation

@EncryptedPixel
Copy link

Changed a bit of chat formatting, looks a lot nicer! :)

@EncryptedPixel EncryptedPixel changed the title Update config.yml Chat Formatting - etc Join Messages, Op default chat color Nov 13, 2015
@EncryptedPixel EncryptedPixel changed the title Chat Formatting - etc Join Messages, Op default chat color Chat Formatting - etc Join Messages, ops-name-color, Nov 13, 2015
@MyPictures
Copy link

35 is a little bit too long for a name and I would like a basic starerkit but otherwise 👍

@Ichbinjoe
Copy link

Can you squash your commits? Once you do I'll give my +1

@EncryptedPixel
Copy link
Author

Ok, I'll change the nick name limit than :)

@Cldfire
Copy link
Contributor

Cldfire commented Nov 13, 2015

I've already implemented better chat / join + quit message format and a some config changes here:

#35

@RoboMWM
Copy link
Contributor

RoboMWM commented Nov 14, 2015

HeroChat is being used for chat messages afaik (no EssentialsChat jar), so your chat formatting changes won't be used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default config does not contain an ampersand, hinting that this config key only accepts one color code. Of course, the comment immediately above this states this as well. You will need to fix this @NexusHD

@RoboMWM
Copy link
Contributor

RoboMWM commented Nov 15, 2015

So, considering there's 2 PRs for changing chat messages and the like, (and since this is still currently broken in its current state,) my vote goes to the other, so 👎 for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants