-
Couldn't load subscription status.
- Fork 134
Chat Formatting - etc Join Messages, ops-name-color, #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
35 is a little bit too long for a name and I would like a basic starerkit but otherwise 👍 |
|
Can you squash your commits? Once you do I'll give my +1 |
|
Ok, I'll change the nick name limit than :) |
|
I've already implemented better chat / join + quit message format and a some config changes here: |
|
HeroChat is being used for chat messages afaik (no EssentialsChat jar), so your chat formatting changes won't be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default config does not contain an ampersand, hinting that this config key only accepts one color code. Of course, the comment immediately above this states this as well. You will need to fix this @NexusHD
|
So, considering there's 2 PRs for changing chat messages and the like, (and since this is still currently broken in its current state,) my vote goes to the other, so 👎 for this one. |
Changed a bit of chat formatting, looks a lot nicer! :)