Skip to content

Conversation

Speykious
Copy link
Owner

FFmpeg makes it very easy to grab screen devices as it is the exact same way we get camera device input.
For the x11grab format though it appears that the function to enumerate devices is not implemented in FFmpeg yet (same problem as #1), so until that becomes a thing we'll have to use X11 ourselves.
Also, using Camera won't make sense for screens so we'll have to do some renaming.

@Speykious Speykious requested a review from adryzz January 29, 2022 14:05
@Speykious Speykious marked this pull request as ready for review January 29, 2022 14:05
@Speykious
Copy link
Owner Author

We got x11grab right but we need to take a look at gdigrab as well, and possibly avfoundation.

@Speykious Speykious mentioned this pull request Feb 1, 2022
@Speykious
Copy link
Owner Author

Looks like it works for gdigrab according to @sr229

@Speykious
Copy link
Owner Author

I'll merge this. It's sad that we don't really have any active devs/testers on MacOS for now but if there, but if there is an issue about that it's gonna be reported eventually.

@Speykious Speykious merged commit 411dcc1 into main Feb 1, 2022
@Speykious Speykious deleted the screen branch February 1, 2022 14:56
@Speykious Speykious restored the screen branch February 1, 2022 14:56
@Speykious Speykious deleted the screen branch February 1, 2022 14:56
@adryzz adryzz mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants