Templating functions - setHeader, initArray, variadic concat #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommysitu
commented
Aug 21, 2025
stuioco
changed the title
tommysitu
commented
Aug 29, 2025
core/templating/templating.go
Outdated
Comment on lines
81
to
98
| //helperMethodMap["concat"] = t.concat | ||
|
|
||
| // Register concatMany to accept a slice of interface{} | ||
| raymond.RemoveHelper("concat") | ||
| raymond.RegisterHelper("concat", func(args ...interface{}) string { | ||
| var parts []string | ||
| for _, arg := range args { | ||
| // If arg is a slice, flatten it | ||
| if s, ok := arg.([]interface{}); ok { | ||
| for _, v := range s { | ||
| parts = append(parts, fmt.Sprint(v)) | ||
| } | ||
| } else { | ||
| parts = append(parts, fmt.Sprint(arg)) | ||
| } | ||
| } | ||
| return strings.Join(parts, "") | ||
| }) |
There was a problem hiding this comment.
do we need this? you have already defined a concat function: bbd9d32#diff-794c9f946ba3753b6d7e501b54401cd2a6029c65ea921f46104e3b3b29c6102fR120
There was a problem hiding this comment.
I have removed the duplication - the manually registered helper now calls the function in template_helpers
tommysitu
commented
Aug 29, 2025
| } else { | ||
| // @todo Maybe we can panic on that | ||
| return reflect.Zero(strType) | ||
| if funcType.IsVariadic() { |
There was a problem hiding this comment.
have we manually updated this file in vendor package?
There was a problem hiding this comment.
Yes, in order to support variadic template helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.