Skip to content

fix: BED-6546 URL encode cypher queries #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirisjo merged 1 commit into from
Oct 9, 2025
Merged

fix: BED-6546 URL encode cypher queries #1962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/javascript/bh-shared-ui/src/views/PrivilegeZones/Cypher/Cypher.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,17 @@ describe('Cypher Search component for Zone Management', () => {
const link = screen.getByRole('link', { name: 'View in Explore' });
expect(link).toHaveAttribute(
'href',
'/ui/explore?searchType=cypher&exploreSearchTab=cypher&cypherSearch=bWF0Y2gobikgcmV0dXJuIG4gbGltaXQgNQ=='
'/ui/explore?searchType=cypher&exploreSearchTab=cypher&cypherSearch=bWF0Y2gobikgcmV0dXJuIG4gbGltaXQgNQ%3D%3D'
);
});

it('properly encodes + sign into the "View in Explore" link', () => {
render(<Cypher initialInput='hello>world' />);

const link = screen.getByRole('link', { name: 'View in Explore' });
expect(link).toHaveAttribute(
'href',
'/ui/explore?searchType=cypher&exploreSearchTab=cypher&cypherSearch=aGVsbG8%2Bd29ybGQ%3D'
);
});

Expand Down
3 changes: 2 additions & 1 deletion packages/javascript/bh-shared-ui/src/views/PrivilegeZones/Cypher/Cypher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ export const Cypher: FC<{
);

const exploreUrl = useMemo(
() => `/ui/explore?searchType=cypher&exploreSearchTab=cypher&cypherSearch=${encodeCypherQuery(cypherQuery)}`,
() =>
`/ui/explore?searchType=cypher&exploreSearchTab=cypher&cypherSearch=${encodeURIComponent(encodeCypherQuery(cypherQuery))}`,
[cypherQuery]
);

Expand Down